Remove needless cleanup (#162)

apache · Nov 24, 2024 · b0ce8f7 · b0ce8f7
1 parent 6c1c802
commit b0ce8f7
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 17 deletions.
diff --git a/...ava/org/apache/maven/plugins/checkstyle/exec/CheckstyleReportListenerMultiSourceTest.java b/...ava/org/apache/maven/plugins/checkstyle/exec/CheckstyleReportListenerMultiSourceTest.java
@@ -28,14 +28,13 @@
 import junit.framework.TestCase;
 
 public class CheckstyleReportListenerMultiSourceTest extends TestCase {
-    private Map<SeverityLevel, CheckstyleCheckerListener> listenerMap;
+    private Map<SeverityLevel, CheckstyleCheckerListener> listenerMap = new HashMap<>();
 
     /**
      * {@inheritDoc}
      */
+    @Override
     protected void setUp() throws Exception {
-        listenerMap = new HashMap<>();
-
         CheckstyleCheckerListener listener = new CheckstyleCheckerListener(new File("/source/path"));
         listener.addSourceDirectory(new File("/source/path2"));
         listener.setSeverityLevelFilter(SeverityLevel.INFO);

diff --git a/src/test/java/org/apache/maven/plugins/checkstyle/exec/CheckstyleReportListenerTest.java b/src/test/java/org/apache/maven/plugins/checkstyle/exec/CheckstyleReportListenerTest.java
@@ -32,12 +32,11 @@
  *
  */
 public class CheckstyleReportListenerTest extends TestCase {
-    private Map<SeverityLevel, CheckstyleCheckerListener> listenerMap;
+    private Map<SeverityLevel, CheckstyleCheckerListener> listenerMap = new HashMap<>();
 
     /** {@inheritDoc} */
+    @Override
     protected void setUp() throws Exception {
-        listenerMap = new HashMap<>();
-
         CheckstyleCheckerListener listener = new CheckstyleCheckerListener(new File("/source/path"));
         listener.setSeverityLevelFilter(SeverityLevel.INFO);
         listenerMap.put(listener.getSeverityLevelFilter(), listener);

diff --git a/src/test/java/org/apache/maven/plugins/checkstyle/exec/CheckstyleResultsTest.java b/src/test/java/org/apache/maven/plugins/checkstyle/exec/CheckstyleResultsTest.java
@@ -34,17 +34,7 @@
  *
  */
 public class CheckstyleResultsTest extends TestCase {
-    private CheckstyleResults results;
-
-    /** {@inheritDoc} */
-    protected void setUp() throws Exception {
-        results = new CheckstyleResults();
-    }
-
-    /** {@inheritDoc} */
-    protected void tearDown() throws Exception {
-        results = null;
-    }
+    private CheckstyleResults results = new CheckstyleResults();
 
     public void testEmptyResults() {
         assertEquals("test total files", 0, results.getFiles().size());