Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSHARED-1430 [MJAR-314] Use the special constant value REPRODUCIBLE_BUILD_STATIC_DATE #72

Closed
wants to merge 1 commit into from

Conversation

stokito
Copy link

@stokito stokito commented Oct 5, 2024

The Gradle has an option preserveFileTimestamps = false that will just put 1 Feb 1980 as a date in Zip archive.
The 1 Jan 1980 is a minimal date in Zip archive but the 1 Jan has some special treatment by Java.
That's why the Gradle team used the 1 Feb.
Introduce a constant value for the outputTimestamp to make an intention clear but also easier to find an explanation for this.

https://issues.apache.org/jira/browse/MJAR-314 / https://issues.apache.org/jira/browse/MSHARED-1430

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MSHARED-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace MSHARED-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its clean verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@slawekjaranowski
Copy link
Member

We should have a separate issue for each component.
When we do release we need an issue to prepare a release notes for each component separately.

@stokito
Copy link
Author

stokito commented Oct 6, 2024

I created the https://issues.apache.org/jira/browse/MSHARED-1430
and https://issues.apache.org/jira/browse/MCOMPILER-600.
But before I mistakenly created a duplicated issue in the maven-jar-pugin https://issues.apache.org/jira/browse/MJAR-314
Please close it

…IC_DATE set the default time

The Gradle has an option preserveFileTimestamps = false that will just put 1 Feb 1980 as a date in Zip archive.
 The 1 Jan 1980 is a minimal date in Zip archive but the 1 Jan has some special treatment by Java.
That's why the Gradle team used the 1 Feb.
Introduce a constant value for the outputTimestamp to make an intention clear but also easier to find an explanation for this.
@hboutemy
Copy link
Member

-1 no
already done in https://issues.apache.org/jira/browse/MNG-8258 in a way that is configurable by project
doing that in this component does not make sense

@stokito
Copy link
Author

stokito commented Oct 10, 2024

Oh I see, so this will be enabled not just for the Maven itself but by default for all projects that use the Maven (including the Maven itself).
Then yes, the PR is not needed. The only thing worth to be changed is the default static time. It would be better to use same date as Gradle use 1 Feb 1980. This was already discussed and while the Maven 4 is in beta it's good time to change it. I'll try the Maven 4 later, maybe I don't need to change anything in a project to get reproducible build.

@stokito stokito closed this Oct 10, 2024
@hboutemy hboutemy changed the title [MJAR-314] Use the special constant value REPRODUCIBLE_BUILD_STATIC_DATE MSHARED-1430 [MJAR-314] Use the special constant value REPRODUCIBLE_BUILD_STATIC_DATE Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants