Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MSHARED-799] Change "Created-By" manifest entry value to be reproducible #4

Merged
merged 1 commit into from
Feb 5, 2019

Conversation

michael-o
Copy link
Member

The test method testCreatedByManifestEntryWithoutMavenVersion() has been
dropped because its function is coverted by two other tests as well.

@michael-o
Copy link
Member Author

Guys, please review

Copy link

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall.
I left a comment

src/main/java/org/apache/maven/archiver/MavenArchiver.java Outdated Show resolved Hide resolved
…ible

The test method testCreatedByManifestEntryWithoutMavenVersion() has been
dropped because its function is coverted by two other tests as well.

This closes #4
@michael-o
Copy link
Member Author

Waiting for @hboutemy

@hboutemy
Copy link
Member

hboutemy commented Feb 4, 2019

@michael-o ok for me

@asfgit asfgit merged commit 7041fca into master Feb 5, 2019
@asfgit asfgit deleted the MSHARED-799 branch February 5, 2019 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants