Fail on invalid 'Automatic-Module-Name' in MANIFEST #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we have the same looking like commit message: The rest looks ok ... |
khmarbaise
requested review from
khmarbaise
and removed request for
khmarbaise
khmarbaise
reviewed
Nov 17, 2018
|
Sure. Renaming the commit message. |
Maven Archiver now fails with a `ManifestException` when an invalid `Automatic-Module-Name` is detected within the `META-INF/MANIFEST.MF` entries. For details see https://sormuras.github.io/blog/2018-11-16-invalid-automatic-module-names https://issues.apache.org/jira/projects/MSHARED/issues/MSHARED-773
sormuras
force-pushed
the
MSHARED-773
branch
from
99b4c6b
to
4c83bf8
Compare
|
Rebased and merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maven Archiver now fails with a
ManifestExceptionwhen an invalidAutomatic-Module-Nameis detected within theMETA-INF/MANIFEST.MFentries.For details see https://sormuras.github.io/blog/2018-11-16-invalid-automatic-module-names
Addresses https://issues.apache.org/jira/projects/MSHARED/issues/MSHARED-773