Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ARCHETYPE-676] Report warning when catalog is not parsable #234

Merged
merged 2 commits into from
Oct 21, 2024
Merged

[ARCHETYPE-676] Report warning when catalog is not parsable #234

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
946e0b2
[ARCHETYPE-676] Report error when catalog is not parsable
Giovds Oct 19, 2024
3c3db16
Only warn with error message unless debug is enabled
Giovds Oct 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion archetype-common/src/main/java/org/apache/maven/archetype/DefaultArchetypeManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,10 @@ public ArchetypeCatalog getInternalCatalog() {

return source.getArchetypeCatalog(null, null);
} catch (ArchetypeDataSourceException e) {
getLogger()
.warn(
"failed to read catalog: " + e.getMessage(),
getLogger().isDebugEnabled() ? e : null);
return new ArchetypeCatalog();
}
}
Expand All @@ -157,6 +161,10 @@ public ArchetypeCatalog getLocalCatalog(RepositorySystemSession repositorySessio

return source.getArchetypeCatalog(repositorySession, null);
} catch (ArchetypeDataSourceException e) {
getLogger()
.warn(
"failed to read catalog: " + e.getMessage(),
getLogger().isDebugEnabled() ? e : null);
return new ArchetypeCatalog();
}
}
Expand All @@ -169,7 +177,10 @@ public ArchetypeCatalog getRemoteCatalog(

return source.getArchetypeCatalog(repositorySession, remoteRepositories);
} catch (ArchetypeDataSourceException e) {
getLogger().warn("failed to download from remote", e);
getLogger()
.warn(
"failed to download from remote" + e.getMessage(),
getLogger().isDebugEnabled() ? e : null);
return new ArchetypeCatalog();
}
}
Expand Down