BREAKING: Lucene.Net.Index.IndexWriter: Fixed Dispose(waitForMerges) vs Dispose(disposing) #749
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #265.
Fixed
Dispose()
overloads so there is no method signature conflict between the publicDispose(waitForMerges)
method and the protectedDispose(disposing)
method which is meant for end users to override. This was done by adding aprotected virtual void Dispose(bool disposing, bool waitForMerges)
overload and removingvirtual
from the publicDispose(bool waitForMerges)
overload.This may break some existing code that either
IndexWriter
and overrides thepublic virtual void Dispose(bool disposing)
method. Instead, the subclass should overrideprotected virtual void Dispose(bool disposing, bool waitForMerges)
.IndexWriter
and implements a finalizer, in which case the call should now callDispose(disposing: false, waitForMerges: true)
. Previously, finalizers were not supported because there was noDispose()
overload to call to pass thedisposing
parameter.