Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lucene.Net.Analysis.Kuromoji.Util.CSVUtil: Fixed QuoteEscape method #712

Merged
merged 1 commit into from
Oct 20, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Lucene.Net.Analysis.Kuromoji/Util/CSVUtil.cs
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ public static string QuoteEscape(string original)

if (result.IndexOf('\"') >= 0)
{
result.Replace("\"", ESCAPED_QUOTE);
result = result.Replace("\"", ESCAPED_QUOTE); // LUCENENET 4.8.0: Applied SOLR-9413 (was fixed in Lucene 6.2/7.0)
}
if (result.IndexOf(COMMA) >= 0)
{
Expand Down
60 changes: 60 additions & 0 deletions src/Lucene.Net.Tests.Analysis.Kuromoji/Util/TestCSVUtil.cs
Original file line number Diff line number Diff line change
@@ -0,0 +1,60 @@
// Lucene version compatibility level 8.2.0
using Lucene.Net.Util;
using NUnit.Framework;
using System;

namespace Lucene.Net.Analysis.Ja.Util
{
/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

/// <summary>
/// Tests for the CSVUtil class.
/// </summary>
public class TestCSVUtil : LuceneTestCase
{
[Test]
public void TestQuoteEscapeQuotes()
{
String input = "\"Let It Be\" is a song and album by the The Beatles.";
String expectedOutput = input.Replace("\"", "\"\"");
ImplTestQuoteEscape(input, expectedOutput);
}

[Test]
public void TestQuoteEscapeComma()
{
String input = "To be, or not to be ...";
String expectedOutput = '"' + input + '"';
ImplTestQuoteEscape(input, expectedOutput);
}

[Test]
public void TestQuoteEscapeQuotesAndComma()
{
String input = "\"To be, or not to be ...\" is a well-known phrase from Shakespeare's Hamlet.";
String expectedOutput = '"' + input.Replace("\"", "\"\"") + '"';
ImplTestQuoteEscape(input, expectedOutput);
}

private void ImplTestQuoteEscape(String input, String expectedOutput)
{
String actualOutput = CSVUtil.QuoteEscape(input);
assertEquals(expectedOutput, actualOutput);
}
}
}