BREAKING: Lucene.Net.Documents.DateTools/Lucene.Net.QueryParser Updates #580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n function and used built-in string formatting to eliminate lots of if-else statements
…tUtil to Lucene.Net.Support
…to specify how the input and output number should be treated when making conversions. De-nested Resolution and enum and renamed DateResolution.
…ded constructor overload to specify date without time (similar to DateFormat.getDateFormat() in Java)
…ded support for converting to/from ticks or ticks as milliseconds.
…use J2N.Numerics types instead of value types to avoid boxing/unboxing
…gle.TryParse() instead of float.Parse() to eliminate exceptions. Use current culture and fallback on invariant culture for Java compatibility.
…ed nullable warnings
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DateTools
TimeZoneInfowhen converting to/from stringNumericRepresentationenum to allow converting to/from long in the following formats:DateTimeorDateTimeOffset.time * TimeSpan.TicksPerMillisecondand the conversion to output values istime / TimeSpan.TicksPerMillisecond.Resolutionenum and renamedDateResolution.QueryParser
Lucene.Net.QueryParsers.Flexible.Standard.Config.NumberDateFormat: Added constructor overload to format a date without a time.Lucene.Net.QueryParsers.Flexible.Standard.Config.NumberDateFormat: AddedNumericRepresentationproperty to set the representation to use for bothFormat()andParse().TimeZoneInfowhen converting to/from string (Classic and Flexible query parsers)Lucene.Net.QueryParsers.Flexible.Standard: Changed numeric nodes to accept and returnJ2N.Numericstypes instead ofobject.Lucene.Net.QueryParsers.Classic.QueryParserBase: UseTryParse()instead ofParse()to parse numeric values. Use the current culture, but fall back to invariant culture.