Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LUCENE-10098: add note/link to GermanAnalyzer for decompounding nouns. #294

Merged
merged 3 commits into from
Sep 12, 2021

Conversation

rmuir
Copy link
Member

@rmuir rmuir commented Sep 12, 2021

We can't do this out of box with the analyzer, due to incompatible
licenses. But we can make it easy on the user to do this, by linking to
repo that has sample code, documentation, and the required data files.

We can't do this out of box with the analyzer, due to incompatible
licenses. But we can make it easy on the user to do this, by linking to
repo that has sample code, documentation, and the required data files.
@rmuir rmuir requested a review from uschindler September 12, 2021 14:37
@uschindler
Copy link
Contributor

uschindler commented Sep 12, 2021

I think this is a good addition.

As owner of the linked repository (https://github.com/uschindler/german-decompounder), I tried to get some more details on the licenses, but it is impossible to include both files needed into Lucene. The dictionary is derived work (done by myself), but the original dictionary is LGPL. See the notice file.

Maybe we should add another sentence to explain that the decompounding requires data files which are incompatible to ASF requirements.

@uschindler
Copy link
Contributor

+1 to Backport (if still possible for 8.10).

@rmuir
Copy link
Member Author

rmuir commented Sep 12, 2021

Thanks @uschindler . I added a phrase about the data files having licenses incompatible with Apache 2.0. I also moved to 8.11 (copying the 8.11 section from branch_8x, it was missing in main).

@rmuir rmuir merged commit 56968b7 into apache:main Sep 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants