Fix bug 'DefaultPassageFormatter.format' method #13832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
dsmiley
reviewed
Oct 1, 2024
lucene/highlighter/src/java/org/apache/lucene/search/uhighlight/DefaultPassageFormatter.java
Outdated
Show resolved
Hide resolved
dsmiley
reviewed
Oct 1, 2024
javanna
reviewed
Oct 3, 2024
| @@ -270,6 +270,9 @@ Bug Fixes | |||
| * GITHUB#12878: Fix the declared Exceptions of Expression#evaluate() to match those | |||
| of DoubleValues#doubleValue(). (Uwe Schindler) | |||
|
|
|||
| * GITHUB#13832: Fixed an issue where the DefaultPassageFormatter.format method did not format passages as intended | |||
| when they were not sorted by startOffset. (Seunghan Jung) | |||
|
|
|||
There was a problem hiding this comment.
This is misplaced. 10.0.0 is feature frozen. It should go to either 10.0.1 or 10.1.0
|
@dsmiley 10.0 is feature frozen, a vote is ongoing. this does need to be backported to branch_10x though it seems, and the changes entry moved to the right place. Please add the appropriate milestone as well? |
|
Oops; thanks for the guidance. It's been a while since I committed/merged in Lucene. I'll move to 10.1.0. |
|
I fixed CHANGES.txt and backported to branch_10x now. |
|
Thanks @dsmiley ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the following PR (#13276), I added an option to allow customizing the sorting of Passages when using the UnifiedHighlighter. As a result, it is no longer guaranteed that the startOffset of the next passage will be greater than that of the previous passage. However, I am now modifying the
DefaultPassageFormatter.format()method, where a conditional statement was written under the assumption that this was guaranteed. You can refer to the test code for examples and better understanding.