Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Map<String,Object> with IntObjectHashMap for DV producer #13686

Merged
merged 3 commits into from
Sep 10, 2024
Merged

Replace Map<String,Object> with IntObjectHashMap for DV producer #13686

merged 3 commits into from
Sep 10, 2024

Conversation

bugmakerrrrrr
Copy link
Contributor

Description

Today, the map between field name and corresponding meta entry in DocValues Producer is represented by a HashMap<String, Object>. To reduce memory usage, we can replace it with an IntObjectHashMap that maps field numbers to meta entries.

jpountz
jpountz approved these changes Sep 5, 2024
View reviewed changes
Copy link
Contributor

@jpountz jpountz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works for me, Lucene90PointsReader already does this.

@bugmakerrrrrr
Copy link
Contributor Author

This works for me, Lucene90PointsReader already does this.

@jpountz I think that we can do the same work for the VectorsReader.

@jpountz jpountz merged commit 6634b41 into apache:main Sep 10, 2024
3 checks passed
@jpountz jpountz added this to the 9.12.0 milestone Sep 10, 2024
jpountz pushed a commit that referenced this pull request Sep 10, 2024
@bugmakerrrrrr @jpountz
Replace Map<String,Object> with IntObjectHashMap for DV producer (#13686
f1606c0 
)
@bugmakerrrrrr bugmakerrrrrr mentioned this pull request Sep 11, 2024
Merged
@benwtrent benwtrent mentioned this pull request Sep 18, 2024
Closed
@ChrisHegarty ChrisHegarty mentioned this pull request Sep 19, 2024
Closed
ChrisHegarty added a commit to ChrisHegarty/lucene that referenced this pull request Sep 19, 2024
@ChrisHegarty
Revert "Replace Map<String,Object> with IntObjectHashMap for DV produ…
f3c03cd 
…cer (apache#13686)"

This reverts commit 6634b41.
@ChrisHegarty ChrisHegarty mentioned this pull request Sep 19, 2024
Merged
ChrisHegarty added a commit to ChrisHegarty/lucene that referenced this pull request Sep 19, 2024
@ChrisHegarty
Revert "Replace Map<String,Object> with IntObjectHashMap for DV produ…
ceda39d 
…cer (apache#13686)"

This reverts commit f1606c0.
@ChrisHegarty ChrisHegarty mentioned this pull request Sep 19, 2024
Merged
ChrisHegarty added a commit that referenced this pull request Sep 20, 2024
@ChrisHegarty
Revert "Replace Map<String,Object> with IntObjectHashMap for DV produ…
7ef7122 
…cer (#13686) (#13810)

Reverts "Replace Map<String,Object> with IntObjectHashMap for DV producer (#13686)

relates #13809
ChrisHegarty added a commit that referenced this pull request Sep 20, 2024
@ChrisHegarty
Revert "Replace Map<String,Object> with IntObjectHashMap for DV produ…
dfc454c 
…cer (#13686)" (#13811)

9.x Revert "Replace Map<String,Object> with IntObjectHashMap for DV producer (#13686)"
@jpountz jpountz modified the milestones: 9.12.0, 10.1.0 Oct 15, 2024
@bugmakerrrrrr bugmakerrrrrr mentioned this pull request Oct 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpountz jpountz jpountz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
10.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@bugmakerrrrrr @jpountz