Move bulkScorer() from Weight to ScorerSupplier #13408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relates to #13359: we want to take advantage of the
Weight#scorerSuppliercall to start scheduling some I/O in the background in parallel across clauses. For this to work properly with top-level disjunctions, we need to move#bulkScorer()fromWeighttoScorerSupplieras well, so that the disjunctiveBooleanQueryfirst performs a call toWeight#scorerSupplier()on all inner clauses, and thenScorerSupplier#bulkScoreron all inner clauses.ScorerSupplier#getandScorerSupplier#bulkScoreronly support being called once. This forced me to fix some inefficiencies inbulkScorer()implementations when we would pull scorers and then throw it away when realizing that the strategy we were planning on using was not optimal. This is why e.g.ReqExclBulkScorernow also supports prohibited clauses that produce a two-phase iterator.