-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
1 parent
9a2d193
commit 2934899
Showing
4 changed files
with
141 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
61 changes: 61 additions & 0 deletions
61
lucene/core/src/java/org/apache/lucene/index/CachingMergeContext.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,61 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package org.apache.lucene.index; | ||
|
|
||
| import java.io.IOException; | ||
| import java.util.HashMap; | ||
| import java.util.Set; | ||
| import org.apache.lucene.util.InfoStream; | ||
|
|
||
| /** | ||
| * a wrapper of IndexWriter MergeContext. Try to cache the {@link | ||
| * #numDeletesToMerge(SegmentCommitInfo)} result in merge phase, to avoid duplicate calculation | ||
| */ | ||
| class CachingMergeContext implements MergePolicy.MergeContext { | ||
| final MergePolicy.MergeContext mergeContext; | ||
| final HashMap<SegmentCommitInfo, Integer> cachedNumDeletesToMerge = new HashMap<>(); | ||
|
|
||
| CachingMergeContext(MergePolicy.MergeContext mergeContext) { | ||
| this.mergeContext = mergeContext; | ||
| } | ||
|
|
||
| @Override | ||
| public final int numDeletesToMerge(SegmentCommitInfo info) throws IOException { | ||
| Integer numDeletesToMerge = cachedNumDeletesToMerge.get(info); | ||
| if (numDeletesToMerge != null) { | ||
| return numDeletesToMerge; | ||
| } | ||
| numDeletesToMerge = mergeContext.numDeletesToMerge(info); | ||
| cachedNumDeletesToMerge.put(info, numDeletesToMerge); | ||
| return numDeletesToMerge; | ||
| } | ||
|
|
||
| @Override | ||
| public final int numDeletedDocs(SegmentCommitInfo info) { | ||
| return mergeContext.numDeletedDocs(info); | ||
| } | ||
|
|
||
| @Override | ||
| public final InfoStream getInfoStream() { | ||
| return mergeContext.getInfoStream(); | ||
| } | ||
|
|
||
| @Override | ||
| public final Set<SegmentCommitInfo> getMergingSegments() { | ||
| return mergeContext.getMergingSegments(); | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
69 changes: 69 additions & 0 deletions
69
lucene/core/src/test/org/apache/lucene/index/TestCachingMergeContext.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,69 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package org.apache.lucene.index; | ||
|
|
||
| import java.io.IOException; | ||
| import java.util.Set; | ||
| import org.apache.lucene.tests.util.LuceneTestCase; | ||
| import org.apache.lucene.util.InfoStream; | ||
|
|
||
| public class TestCachingMergeContext extends LuceneTestCase { | ||
| public void testNumDeletesToMerge() throws IOException { | ||
| MockMergeContext mergeContext = new MockMergeContext(); | ||
| CachingMergeContext cachingMergeContext = new CachingMergeContext(mergeContext); | ||
| assertEquals(cachingMergeContext.numDeletesToMerge(null), 1); | ||
| assertEquals(cachingMergeContext.cachedNumDeletesToMerge.size(), 1); | ||
| assertEquals( | ||
| cachingMergeContext.cachedNumDeletesToMerge.getOrDefault(null, -1), Integer.valueOf(1)); | ||
| assertEquals(mergeContext.count, 1); | ||
|
|
||
| // increase the mock count | ||
| mergeContext.numDeletesToMerge(null); | ||
| assertEquals(mergeContext.count, 2); | ||
|
|
||
| // assert the cache result still one | ||
| assertEquals(cachingMergeContext.numDeletesToMerge(null), 1); | ||
| assertEquals(cachingMergeContext.cachedNumDeletesToMerge.size(), 1); | ||
| assertEquals( | ||
| cachingMergeContext.cachedNumDeletesToMerge.getOrDefault(null, -1), Integer.valueOf(1)); | ||
| } | ||
|
|
||
| private static final class MockMergeContext implements MergePolicy.MergeContext { | ||
| int count = 0; | ||
|
|
||
| @Override | ||
| public final int numDeletesToMerge(SegmentCommitInfo info) throws IOException { | ||
| this.count += 1; | ||
| return this.count; | ||
| } | ||
|
|
||
| @Override | ||
| public int numDeletedDocs(SegmentCommitInfo info) { | ||
| return 0; | ||
| } | ||
|
|
||
| @Override | ||
| public InfoStream getInfoStream() { | ||
| return null; | ||
| } | ||
|
|
||
| @Override | ||
| public Set<SegmentCommitInfo> getMergingSegments() { | ||
| return null; | ||
| } | ||
| } | ||
| } |