Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LUCENE-8746: Component2D topology library that works on encoded space #770

Closed
wants to merge 15 commits into from

Conversation

iverase
Copy link
Contributor

@iverase iverase commented Jul 8, 2019

With the upcoming of a new Shape type working in cartesian space (#726), I think we need to put some structure in the objects that contain spatial logic. In particular I have tried to remove all the mixed notation between latitude/longitude and x/y as well as defined factory methods to create those shapes from LatLonShape.

This library chooses to use X/Y notation as it is mainly cartesian, it works on the encoding space and solves problems like the neighbourhood issue (https://discuss.elastic.co/t/neighboring-touching-geo-shapes-not-found/175543) when not encoded query shapes are used against encoded indexed shapes. It potentially can simplify all the query logic as it is only needed a query by Component2D for this case.

Currently it contains factory methods to create Component2D shapes from LatLonShapes, it should be trivial to add a factory class for XYShapes.

@jpountz @nknize @rmuir @dsmiley let me know what do you think?

@iverase
Copy link
Contributor Author

iverase commented Jul 10, 2019

After merging master with XYShape, it seems clear that this approach won't work for that encoding as it is not linear and shapes in the encoded space have different properties.

@iverase
Copy link
Contributor Author

iverase commented Sep 13, 2019

Closing this PR. I am opening a new one with narrow scope

@iverase iverase closed this Sep 13, 2019
@iverase iverase deleted the component2D branch February 7, 2020 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant