Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LUCENE-9722: Close merged readers on abort #2288

Merged
merged 3 commits into from
Feb 2, 2021
Merged

Conversation

dnhatn
Copy link
Member

@dnhatn dnhatn commented Feb 2, 2021

IndexWriter fails to close the merged readers of an aborted merge if the output segment contains no document.

This bug was discovered by a test in Elasticsearch (elastic/elasticsearch#67884).

Copy link
Member

@s1monw s1monw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM sneaky

@dnhatn
Copy link
Member Author

dnhatn commented Feb 2, 2021

Thanks Simon.

@dnhatn dnhatn merged commit 47e3d06 into apache:master Feb 2, 2021
@dnhatn dnhatn deleted the LUCENE-9722 branch February 2, 2021 16:24
asfgit pushed a commit that referenced this pull request Feb 2, 2021
We fail to close the merged readers of an aborted merge if its 
output segment contains no document.

This bug was discovered by a test in Elasticsearch 
(elastic/elasticsearch#67884).
asfgit pushed a commit that referenced this pull request Feb 2, 2021
We fail to close the merged readers of an aborted merge if its 
output segment contains no document.

This bug was discovered by a test in Elasticsearch 
(elastic/elasticsearch#67884).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants