Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix off-by-one in StackTraceStringResolver #3216

Merged
merged 3 commits into from
Nov 18, 2024

Conversation

vy
Copy link
Member

@vy vy commented Nov 18, 2024

Fixes #3194, ports #3212.

@vy vy added bug Incorrect, unexpected, or unintended behavior of existing code layouts Affects one or more Layout plugins labels Nov 18, 2024
@vy vy added this to the 2.24.2 milestone Nov 18, 2024
@vy vy self-assigned this Nov 18, 2024
Copy link
Contributor

@ppkarwasz ppkarwasz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ppkarwasz ppkarwasz merged commit efba2fb into 2.24.x Nov 18, 2024
5 checks passed
@ppkarwasz ppkarwasz deleted the fix/2.24.x/JTL-StackTraceStringResolver branch November 18, 2024 19:51
ppkarwasz pushed a commit that referenced this pull request Nov 21, 2024
dongjoon-hyun pushed a commit to apache/spark that referenced this pull request Nov 24, 2024
### What changes were proposed in this pull request?
The pr aims to upgrade log4j2 from `2.24.1` to `2.24.2`.

### Why are the changes needed?
- The full release notes:
https://github.com/apache/logging-log4j2/releases/tag/rel%2F2.24.2

- This release fixes a critical bug in Log4j API initialization code, which can cause LogManager.getLogger() to return null under certain conditions. See apache/logging-log4j2#3143 for details.
  Fix key removal issues in Thread Context (apache/logging-log4j2#3048)
  Use hard references to Loggers in LoggerRegistry. (apache/logging-log4j2#3143)
  Fix ArrayIndexOutOfBoundsException in JSON Template Layout truncated exception resolver (apache/logging-log4j2#3216)

### Does this PR introduce _any_ user-facing change?
No.

### How was this patch tested?
Pass GA.

### Was this patch authored or co-authored using generative AI tooling?
No.

Closes #48945 from panbingkun/SPARK-50400.

Authored-by: panbingkun <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Incorrect, unexpected, or unintended behavior of existing code layouts Affects one or more Layout plugins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants