-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prefix stack traces with a newline in Pattern Layout #3045
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…feature/2.x/ex-newline # Conflicts: # src/changelog/.2.x.x/.release-notes.adoc.ftl
vy
changed the title
Suffix pattern with
Prefix stack traces with a newline in Pattern Layout
Oct 7, 2024
%n%xEx
in Pattern Layout
ppkarwasz
requested changes
Oct 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job! 💯
I didn't check everything in details, but we could profit from the rewrite to modernize a little bit how our tests run.
log4j-core-test/src/test/java/org/apache/logging/log4j/core/EventParameterMemoryLeakTest.java
Outdated
Show resolved
Hide resolved
.../src/test/java/org/apache/logging/log4j/core/impl/NestedLoggingFromThrowableMessageTest.java
Show resolved
Hide resolved
...test/java/org/apache/logging/log4j/core/layout/PatternLayoutDefaultExceptionHandlerTest.java
Show resolved
Hide resolved
...n/java/org/apache/logging/log4j/core/pattern/ThrowableExtendedStackTraceRendererFactory.java
Outdated
Show resolved
Hide resolved
...n/java/org/apache/logging/log4j/core/pattern/ThrowableInvertedStackTraceRendererFactory.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/apache/logging/log4j/core/pattern/ThrowableStackTraceRendererFactory.java
Show resolved
Hide resolved
...re/src/main/java/org/apache/logging/log4j/core/pattern/ThrowablePropertyRendererFactory.java
Show resolved
Hide resolved
.../src/main/java/org/apache/logging/log4j/layout/template/json/JsonTemplateLayoutDefaults.java
Show resolved
Hide resolved
Co-authored-by: Piotr P. Karwasz <piotr@github.copernik.eu>
Co-authored-by: Piotr P. Karwasz <piotr@github.copernik.eu>
…feature/2.x/ex-newline
ppkarwasz
approved these changes
Oct 9, 2024
vy
added a commit
that referenced
this pull request
Oct 9, 2024
- Exception converters are reworked to ensure a newline prefix (which used to be a whitespace) - Fix property extraction for root exceptions (e.g., %rEx{short.className}) Co-authored-by: AlanYu <alan0428a@gmail.com> Co-authored-by: Piotr P. Karwasz <piotr@github.copernik.eu>
vy
added a commit
that referenced
this pull request
Oct 10, 2024
- Exception converters are reworked to ensure a newline prefix (which used to be a whitespace) - Fix property extraction for root exceptions (e.g., %rEx{short.className}) - Ports #3045 Co-authored-by: AlanYu <alan0428a@gmail.com> Co-authored-by: Piotr P. Karwasz <piotr@github.copernik.eu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This work is a follow-up of #2691 and implements the following changes:
%rEx{short.className}
)