Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement MessageFactory-namespaced logger registry #2961

Merged
merged 3 commits into from
Sep 17, 2024
Merged

Implement MessageFactory-namespaced logger registry #2961

merged 3 commits into from
Sep 17, 2024

Conversation

vy
Copy link
Member

@vy vy commented Sep 16, 2024 •
edited
Loading

Ports #2936 fixing #2933 in 2.x to 2.24.x.

@vy vy added bug Incorrect, unexpected, or unintended behavior of existing code api Affects the public API labels Sep 16, 2024
@vy vy added this to the 2.24.1 milestone Sep 16, 2024
@vy vy requested a review from ppkarwasz September 16, 2024 18:57
@vy vy self-assigned this Sep 16, 2024
ppkarwasz
ppkarwasz requested changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@ppkarwasz ppkarwasz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except some minor remarks.

log4j-api/src/main/java/org/apache/logging/log4j/spi/LoggerRegistry.java Outdated Show resolved Hide resolved
log4j-core/src/main/java/org/apache/logging/log4j/core/LoggerContext.java Show resolved Hide resolved
log4j-core/src/main/java/org/apache/logging/log4j/core/LoggerContext.java Show resolved Hide resolved
log4j-core/src/main/java/org/apache/logging/log4j/core/LoggerContext.java Outdated Show resolved Hide resolved
@vy vy merged commit 2062676 into 2.24.x Sep 17, 2024
7 checks passed
@vy vy deleted the fix/2.24.x/LoggerRegistry-revamp branch September 17, 2024 18:39
vy added a commit that referenced this pull request Sep 17, 2024
@vy
Improvements on the logger message factory namespacing (#2961)
6fdab69
@ppkarwasz ppkarwasz removed this from the 2.24.1 milestone Sep 18, 2024
This was referenced Nov 11, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppkarwasz ppkarwasz ppkarwasz approved these changes

Assignees

@vy vy

Labels
api Affects the public API bug Incorrect, unexpected, or unintended behavior of existing code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vy @ppkarwasz