-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Issue2281] The core.Logger#setLevel method should work like Configurator#setLevel() #2289
Conversation
Note that the new test fails... @ppkarwasz |
Are we testing the right thing? Unless I am mistaken JUL's Unfortunately the effective level can be only be guessed by calling I think that our |
22e5a86
to
ac0633b
Compare
Ah, good point on the tests, I updated the tests to use |
ac0633b
to
aacad7c
Compare
log4j-jul/src/test/java/org/apache/logging/log4j/jul/test/CoreLoggerTest.java
Outdated
Show resolved
Hide resolved
Configurator#setLevel apache#2281 Do for this module what we did for log4j-1.2-api
aacad7c
to
5665776
Compare
log4j-jul/src/test/java/org/apache/logging/log4j/jul/test/CoreLoggerTest.java
Outdated
Show resolved
Hide resolved
…LoggerTest.java Co-authored-by: Piotr P. Karwasz <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@ppkarwasz |
Do for this module what we did for
log4j-1.2-api
.