LOG4J2-3114 - Enable immediate flush on RollingFileAppender when buff…

…ered i/o is not enabled.
apache · Nov 21, 2021 · 5e5e598 · 5e5e598
1 parent 9f55c38
commit 5e5e598
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/RollingFileAppender.java b/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/RollingFileAppender.java
@@ -153,8 +153,8 @@ isBufferedIo, policy, strategy, advertiseUri, layout, bufferSize, isImmediateFlu
             manager.initialize();
 
             return new RollingFileAppender(getName(), layout, getFilter(), manager, fileName, filePattern,
-                    isIgnoreExceptions(), isImmediateFlush(), advertise ? getConfiguration().getAdvertiser() : null,
-                    getPropertyArray());
+                    isIgnoreExceptions(), !isBufferedIo || isImmediateFlush(),
+                    advertise ? getConfiguration().getAdvertiser() : null, getPropertyArray());
         }
 
         public String getAdvertiseUri() {

diff --git a/src/changes/changes.xml b/src/changes/changes.xml
@@ -107,6 +107,9 @@
         Improve PatternLayout performance by reducing unnecessary indirection and branching.
       </action>
       <!-- FIXES -->
+      <action issue="LOG4J2-3114" dev="rgoers" type="fix" due-to="Barnabas Bodnar">
+        Enable immediate flush on RollingFileAppender when buffered i/o is not enabled.
+      </action>
       <action issue="LOG4J2-3168" dev="rgoers" type="fix" due-to="Benjamin Wöster">
        Fix bug when file names contain regex characters.
       </action>