Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add codecov git action to track test coverage metrics #1945

Merged
merged 4 commits into from
Apr 12, 2022

Conversation

husofskyzy
Copy link
Contributor

@husofskyzy husofskyzy commented Apr 12, 2022

What is the purpose of the change

add codecov git action to track test coverage metrics #1946

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes)

@casionone casionone changed the title Submit test coverage codecov Add codecov git action to track test coverage metrics Apr 12, 2022
peacewong
peacewong previously approved these changes Apr 12, 2022
Copy link
Contributor

@peacewong peacewong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@casionone
Copy link
Contributor

https://github.com/apache/incubator-linkis/runs/5983197735?check_suite_focus=true

[2022-04-12T03:08:46.318Z] ['info'] => Project root located at: /home/runner/work/incubator-linkis/incubator-linkis
[2022-04-12T03:08:46.319Z] ['info'] -> No token specified or token is empty
[2022-04-12T03:08:46.332Z] ['info'] Searching for coverage files...
[2022-04-12T03:08:47.1[25](https://github.com/apache/incubator-linkis/runs/5983197735?check_suite_focus=true#step:7:25)Z] ['info'] Warning: Some files located via search were excluded from upload.
[2022-04-12T03:08:47.125Z] ['info'] If Codecov did not locate your files, please review https://docs.codecov.com/docs/supported-report-formats
[2022-04-12T03:08:47.125Z] ['error'] There was an error running the uploader: No coverage files located, please try use `-f`, or change the project root with `-R`

Some error log info ['error'] There was an error running the uploader: No coverage files located, please try use-f, or change the project root with -R`

@codecov
Copy link

codecov bot commented Apr 12, 2022

Codecov Report

❗ No coverage uploaded for pull request base (master@85dca85). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1945   +/-   ##
=========================================
  Coverage          ?   16.89%           
  Complexity        ?      526           
=========================================
  Files             ?      280           
  Lines             ?     8709           
  Branches          ?     1273           
=========================================
  Hits              ?     1471           
  Misses            ?     7086           
  Partials          ?      152           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85dca85...6b5e0c5. Read the comment docs.

Copy link
Contributor

@peacewong peacewong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@peacewong peacewong merged commit e7e144c into apache:master Apr 12, 2022
@javeme
Copy link

javeme commented Apr 20, 2022

@husofskyzy Hi, I'm from the Apache HugeGraph(incubator) team, and we are currently encountering a codecov issue, Can I ask some questions?

After we migrated the hugegraph project to apache, codecov could not send the report to the github PR. It seems OK for linkis PR, what operations you have done? Do you installed the codecov app for linkis repository? Thanks~

@husofskyzy
Copy link
Contributor Author

@husofskyzy Hi, I'm from the Apache HugeGraph(incubator) team, and we are currently encountering a codecov issue, Can I ask some questions?

After we migrated the hugegraph project to apache, codecov could not send the report to the github PR. It seems OK for linkis PR, what operations you have done? Do you installed the codecov app for linkis repository? Thanks~

yes,we have installed the codecov app.you can see the file change in this PR.

@javeme
Copy link

javeme commented Apr 20, 2022

Thank you.
We also update .github/workflows/ci.yml, but codecov still could not send the report to the github PR. Do you mean the codecov app is installed in github settings/installations location https://github.com/apache/incubator-linkis/settings/installations ?

Like this location:
image

saLeox pushed a commit to saLeox/Linkis that referenced this pull request Jun 6, 2022
* 提交测试覆盖率

* Update pom.xml

update

* Update pom.xml

* Update pom.xml
casionone added a commit that referenced this pull request Jun 8, 2022
* Add codecov git action to track test coverage metrics (#1945)

* enable prometheus monitoring
* Enable to specify the port range of engine conn(EC)
* Enable prometheus in install script

Co-authored-by: Casion <[email protected]>
Co-authored-by: husofskyzy <[email protected]>
Co-authored-by: peacewong <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants