[KYUUBI #6843] Fix 'query-timeout-thread' thread leak #6844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please fix the failed checks. |
|
@ASiegeLion please write the PR description seriously, and revert unnecessary code changes. |
ok |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6844 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 687 687
Lines 42463 42467 +4
Branches 5796 5796
======================================
- Misses 42463 42467 +4 ☔ View full report in Codecov by Sentry. |
|
We also fixed this issue a few months ago. cc @lsm1 |
pan3793
changed the title
|
@ASiegeLion In other engines, there might be the same issue. Please fix it. |
pan3793
pushed a commit
that referenced
this pull request
Dec 27, 2024
### Why are the changes needed? see #6843 If the session manager's ThreadPoolExecutor refuses to execute asyncOperation, then we need to shut down the query-timeout-thread in the catch ### How was this patch tested? 1 Use jstack to view threads on the long-lived engine side  2 Wait for all SQL statements in the engine to finish executing, and then use stack to check the number of query-timeout-thread threads, which should be empty.  ### Was this patch authored or co-authored using generative AI tooling? NO Closes #6844 from ASiegeLion/master. Closes #6843 9107a30 [liupeiyue] [KYUUBI #6843] FIX 'query-timeout-thread' thread leak 4b3417f [liupeiyue] [KYUUBI #6843] FIX 'query-timeout-thread' thread leak ef1f66b [liupeiyue] [KYUUBI #6843] FIX 'query-timeout-thread' thread leak 9e1a015 [liupeiyue] [KYUUBI #6843] FIX 'query-timeout-thread' thread leak 78a9fde [liupeiyue] [KYUUBI #6843] FIX 'query-timeout-thread' thread leak Authored-by: liupeiyue <[email protected]> Signed-off-by: Cheng Pan <[email protected]> (cherry picked from commit a051253) Signed-off-by: Cheng Pan <[email protected]>
pan3793
pushed a commit
that referenced
this pull request
Dec 27, 2024
### Why are the changes needed? see #6843 If the session manager's ThreadPoolExecutor refuses to execute asyncOperation, then we need to shut down the query-timeout-thread in the catch ### How was this patch tested? 1 Use jstack to view threads on the long-lived engine side  2 Wait for all SQL statements in the engine to finish executing, and then use stack to check the number of query-timeout-thread threads, which should be empty.  ### Was this patch authored or co-authored using generative AI tooling? NO Closes #6844 from ASiegeLion/master. Closes #6843 9107a30 [liupeiyue] [KYUUBI #6843] FIX 'query-timeout-thread' thread leak 4b3417f [liupeiyue] [KYUUBI #6843] FIX 'query-timeout-thread' thread leak ef1f66b [liupeiyue] [KYUUBI #6843] FIX 'query-timeout-thread' thread leak 9e1a015 [liupeiyue] [KYUUBI #6843] FIX 'query-timeout-thread' thread leak 78a9fde [liupeiyue] [KYUUBI #6843] FIX 'query-timeout-thread' thread leak Authored-by: liupeiyue <[email protected]> Signed-off-by: Cheng Pan <[email protected]> (cherry picked from commit a051253) Signed-off-by: Cheng Pan <[email protected]>
|
Seems the contributor is slient a while, let me merge this, and @lsm1 could you please send a followup to cover the rest? |
|
Merged to 1.11.0/1.10.2/1.9.4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
see #6843
If the session manager's ThreadPoolExecutor refuses to execute asyncOperation, then we need to shut down the query-timeout-thread in the catch
How was this patch tested?
1 Use jstack to view threads on the long-lived engine side
2 Wait for all SQL statements in the engine to finish executing, and then use stack to check the number of query-timeout-thread threads, which should be empty.
Was this patch authored or co-authored using generative AI tooling?
NO