Ship kafka-clients in binary distribution tarball without compression libs
#6836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
kind:infra
pan3793
commented
Dec 4, 2024
| @@ -1053,7 +1053,20 @@ | |||
| <groupId>org.apache.kafka</groupId> | |||
| <artifactId>kafka-clients</artifactId> | |||
| <version>${kafka.version}</version> | |||
| <optional>true</optional> | |||
There was a problem hiding this comment.
seems the build/dependency.sh does not correctly handle optional
pan3793
commented
Dec 4, 2024
| @@ -306,8 +306,6 @@ io.vertx:vertx-grpc | |||
| com.squareup.retrofit2:retrofit | |||
| com.squareup.okhttp3:okhttp | |||
| org.apache.kafka:kafka-clients | |||
| org.lz4:lz4-java | |||
| org.xerial.snappy:snappy-java | |||
There was a problem hiding this comment.
the LICENSE/NOTICE should match the real content of artifacts
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6836 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 687 687
Lines 42441 42441
Branches 5793 5793
======================================
Misses 42441 42441 ☔ View full report in Codecov by Sentry. |
turboFei
approved these changes
Dec 5, 2024
bowenliang123
approved these changes
Dec 5, 2024
pan3793
added a commit
that referenced
this pull request
Dec 5, 2024
…thout compression libs ### Why are the changes needed? I'd like to include `kafka-clients` in the Kyuubi binary distribution tarball to enable the out-of-box support for sinking Kyuubi events to Kafka. - Kafka is an important component in modern data platforms, and is a defacto message queue implementation, especially in the big data domain - `kafka-clients` is released under Apache License V2, has no legal issue - `kafka-clients` is quite a light lib, has no third-party deps except for `slf4j-api` and a few optional compression libs - `kafka-clients` uses "none" compression as default, in practice, "gzip"(delegate to JDK gzip algorithm, no additional libs are required) already performs well for non-extreme cases Additionally, LOG4J2 has a built-in `KafkaAppender` that supports sinking logging to Kafka, which also requires `kafka-clients` in the classpath, I have some initial ideas to forward both Kyuubi server's and engine bootstrap processes log to Kafka in a structured format, will send another PR to add docs to guide users in configuring that. ### How was this patch tested? Review ### Was this patch authored or co-authored using generative AI tooling? No. Closes #6836 from pan3793/kafka-lib. Closes #6836 b069eb1 [Cheng Pan] Ship kafka-clients in binary distribution tarball without compression libs Authored-by: Cheng Pan <[email protected]> Signed-off-by: Cheng Pan <[email protected]> (cherry picked from commit f2cacd3) Signed-off-by: Cheng Pan <[email protected]>
|
Thanks, merged to master/1.10 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
I'd like to include
kafka-clientsin the Kyuubi binary distribution tarball to enable the out-of-box support for sinking Kyuubi events to Kafka.kafka-clientsis released under Apache License V2, has no legal issuekafka-clientsis quite a light lib, has no third-party deps except forslf4j-apiand a few optional compression libskafka-clientsuses "none" compression as default, in practice, "gzip"(delegate to JDK gzip algorithm, no additional libs are required) already performs well for non-extreme casesAdditionally, LOG4J2 has a built-in
KafkaAppenderthat supports sinking logging to Kafka, which also requireskafka-clientsin the classpath, I have some initial ideas to forward both Kyuubi server's and engine bootstrap processes log to Kafka in a structured format, will send another PR to add docs to guide users in configuring that.How was this patch tested?
Review
Was this patch authored or co-authored using generative AI tooling?
No.