Clean up and improve error message for KyuubiBaseResultSet #6828
+176
−109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pan3793
commented
Nov 28, 2024
| } | ||
| } catch (Exception e) { | ||
| throw new KyuubiSQLException("Cannot convert column " + columnIndex + " to date: " + e, e); |
There was a problem hiding this comment.
it's horrible that the previously reported error message does not contain the illegal data!
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6828 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 687 687
Lines 42439 42439
Branches 5791 5792 +1
======================================
Misses 42439 42439 ☔ View full report in Codecov by Sentry. |
|
scala 2.13 test failure is irrelevant |
turboFei
approved these changes
Nov 29, 2024
pan3793
added a commit
that referenced
this pull request
Nov 29, 2024
…tSet ### Why are the changes needed? Backport apache/hive@2b0e424 The commit does not have a Hive ticket. ### How was this patch tested? Pass GHA to ensure it breaks nothing, and verify locally that the reported error message does contain the data when failing to parse the illegal date.  ### Was this patch authored or co-authored using generative AI tooling? No. Closes #6828 from pan3793/hive-jdbc-2b0e424. Closes #6828 b6e03a6 [Cheng Pan] KyuubiSQLException 63861af [Cheng Pan] Backport Hive 2b0e424 - Clean up and improve error message for KyuubiBaseResultSet Authored-by: Cheng Pan <[email protected]> Signed-off-by: Cheng Pan <[email protected]> (cherry picked from commit 68a6f48) Signed-off-by: Cheng Pan <[email protected]>
pan3793
added a commit
that referenced
this pull request
Nov 29, 2024
…tSet ### Why are the changes needed? Backport apache/hive@2b0e424 The commit does not have a Hive ticket. ### How was this patch tested? Pass GHA to ensure it breaks nothing, and verify locally that the reported error message does contain the data when failing to parse the illegal date.  ### Was this patch authored or co-authored using generative AI tooling? No. Closes #6828 from pan3793/hive-jdbc-2b0e424. Closes #6828 b6e03a6 [Cheng Pan] KyuubiSQLException 63861af [Cheng Pan] Backport Hive 2b0e424 - Clean up and improve error message for KyuubiBaseResultSet Authored-by: Cheng Pan <[email protected]> Signed-off-by: Cheng Pan <[email protected]> (cherry picked from commit 68a6f48) Signed-off-by: Cheng Pan <[email protected]>
|
Thanks, merged to master/1.10.1/1.9.3 |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Backport apache/hive@2b0e424
The commit does not have a Hive ticket.
How was this patch tested?
Pass GHA to ensure it breaks nothing, and verify locally that the reported error message does contain the data when failing to parse the illegal date.
Was this patch authored or co-authored using generative AI tooling?
No.