[BUILD] Replace java.version 1.8 with 8
#6813
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pan3793
approved these changes
Nov 19, 2024
bowenliang123
changed the title
bowenliang123
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6813 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 687 687
Lines 42442 42442
Branches 5793 5793
======================================
Misses 42442 42442 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
yaooqinn
approved these changes
Nov 19, 2024
pan3793
changed the title
java.version 1.8 with 8
pan3793
pushed a commit
that referenced
this pull request
Nov 19, 2024
This pull request fixes # - fix the compilation error on Zulu JDK8 (Zulu 8.82.0.21-cA-macos-aarch64 with M4 Max chip on MacOS 15.1), when running `build/mvn clean install -pl :kyuubi-util -DskipTests -am` command to build a pure Java module, by replacing version code sytle from 1.8 to 8.  - [ ] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) --- - [ ] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html) **Be nice. Be informative.** Closes #6813 from bowenliang123/java8. Closes #6813 1a1e3f3 [Bowen Liang] set java.version to 8 Authored-by: Bowen Liang <[email protected]> Signed-off-by: Cheng Pan <[email protected]> (cherry picked from commit c391d16) Signed-off-by: Cheng Pan <[email protected]>
pan3793
pushed a commit
that referenced
this pull request
Nov 19, 2024
This pull request fixes # - fix the compilation error on Zulu JDK8 (Zulu 8.82.0.21-cA-macos-aarch64 with M4 Max chip on MacOS 15.1), when running `build/mvn clean install -pl :kyuubi-util -DskipTests -am` command to build a pure Java module, by replacing version code sytle from 1.8 to 8.  - [ ] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) --- - [ ] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html) **Be nice. Be informative.** Closes #6813 from bowenliang123/java8. Closes #6813 1a1e3f3 [Bowen Liang] set java.version to 8 Authored-by: Bowen Liang <[email protected]> Signed-off-by: Cheng Pan <[email protected]> (cherry picked from commit c391d16) Signed-off-by: Cheng Pan <[email protected]>
|
thanks, merged to master/1.10.1/1.9.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔍 Description
Issue References 🔗
This pull request fixes #
Describe Your Solution 🔧
build/mvn clean install -pl :kyuubi-util -DskipTests -amcommand to build a pure Java module, by replacing version code sytle from 1.8 to 8.Types of changes 🔖
Test Plan 🧪
Behavior Without This Pull Request ⚰️
Behavior With This Pull Request 🎉
Related Unit Tests
Checklist 📝
Be nice. Be informative.