Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KYUUBI #6704] Disable periodic gc if set interval to 0 #6725

Closed
wants to merge 11 commits into from

Conversation

taylor12805
Copy link

🔍 Description

Issue References 🔗

This pull request fixes #6704

Describe Your Solution 🔧

if periodic gc is set to 0, there is no need to perform an explicit gc.

Types of changes 🔖

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Test Plan 🧪

Behavior Without This Pull Request ⚰️

Behavior With This Pull Request 🎉

Related Unit Tests


Checklist 📝

Be nice. Be informative.

@taylor12805 taylor12805 changed the title disable periodic gc if set interval to 0 [KYUUBI #6704] disable periodic gc if set interval to 0 Oct 14, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (2d64255) to head (a52ddda).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
...a/org/apache/kyuubi/server/PeriodicGCService.scala 0.00% 8 Missing ⚠️
...in/scala/org/apache/kyuubi/config/KyuubiConf.scala 0.00% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##           master   #6725   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files         684     684           
  Lines       42282   42283    +1     
  Branches     5767    5768    +1     
======================================
- Misses      42282   42283    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pan3793
Copy link
Member

pan3793 commented Oct 15, 2024

behavior change looks good to me, would you mind updating the doc of kyuubi.periodicGC.interval to mention that?

@bowenliang123
Copy link
Contributor

@taylor12805 Please update the document for kyuubi.server.periodicGC.interval in KyuubiConf class, and then run dev/gen/gen_all_config_docs.sh script to update the markdown docs. Thanks for your contribution.

@github-actions github-actions bot added the kind:documentation Documentation is a feature! label Oct 15, 2024
@github-actions github-actions bot removed the kind:documentation Documentation is a feature! label Oct 15, 2024
@taylor12805
Copy link
Author

behavior change looks good to me, would you mind updating the doc of kyuubi.periodicGC.interval to mention that?

@taylor12805 Please update the document for kyuubi.server.periodicGC.interval in KyuubiConf class, and then run dev/gen/gen_all_config_docs.sh script to update the markdown docs. Thanks for your contribution.

sure, i have updated the document

@github-actions github-actions bot added the kind:documentation Documentation is a feature! label Oct 15, 2024
@pan3793
Copy link
Member

pan3793 commented Oct 15, 2024

@taylor12805 you need to modify the code and regenerate the md

.doc("How often to trigger a garbage collection.")

@taylor12805
Copy link
Author

@taylor12805 you need to modify the code and regenerate the md

.doc("How often to trigger a garbage collection.")

yeah, sure, i have figured that out

@pan3793 pan3793 changed the title [KYUUBI #6704] disable periodic gc if set interval to 0 [KYUUBI #6704] Disable periodic gc if set interval to 0 Oct 16, 2024
@pan3793 pan3793 closed this in 851fb5a Oct 16, 2024
@pan3793
Copy link
Member

pan3793 commented Oct 16, 2024

Thanks, merged to master for 1.10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement] disable periodic GC interval if not necessary
5 participants