-
Notifications
You must be signed in to change notification settings - Fork 917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[KYUUBI #6704] Disable periodic gc if set interval to 0 #6725
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6725 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 684 684
Lines 42282 42283 +1
Branches 5767 5768 +1
======================================
- Misses 42282 42283 +1 ☔ View full report in Codecov by Sentry. |
behavior change looks good to me, would you mind updating the |
@taylor12805 Please update the document for |
sure, i have updated the document |
@taylor12805 you need to modify the code and regenerate the md
|
yeah, sure, i have figured that out |
Thanks, merged to master for 1.10 |
🔍 Description
Issue References 🔗
This pull request fixes #6704
Describe Your Solution 🔧
if periodic gc is set to 0, there is no need to perform an explicit gc.
Types of changes 🔖
Test Plan 🧪
Behavior Without This Pull Request ⚰️
Behavior With This Pull Request 🎉
Related Unit Tests
Checklist 📝
Be nice. Be informative.