Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AppState when Engine connection is terminated #6722

Closed
wants to merge 9 commits into from
+11 −1
Closed

Fix AppState when Engine connection is terminated #6722

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
215ac66
Fix AppState when Engine connection is terminated
joaopamaral Oct 7, 2024
3a3ba16
Fix
joaopamaral Oct 7, 2024
60ce55e
add todo
joaopamaral Oct 7, 2024
13498fa
Remove test
joaopamaral Oct 8, 2024
1eb80ef
Remove test
joaopamaral Oct 8, 2024
64f96a2
Remove test
joaopamaral Oct 8, 2024
73b77b3
use isTerminated
joaopamaral Oct 8, 2024
da8c356
format fix
joaopamaral Oct 22, 2024
8409eac
fix
turboFei Nov 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion kyuubi-server/src/main/scala/org/apache/kyuubi/operation/BatchJobSubmission.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,13 +154,23 @@ class BatchJobSubmission(
engineId = appInfo.id,
engineName = appInfo.name,
engineUrl = appInfo.url.orNull,
engineState = appInfo.state.toString,
engineState = getAppState(state, appInfo.state).toString,
engineError = appInfo.error,
endTime = endTime)
session.sessionManager.updateMetadata(metadataToUpdate)
}
}

private def getAppState(
opState: OperationState,
appState: ApplicationState.ApplicationState): ApplicationState.ApplicationState = {
if (opState == OperationState.ERROR && !ApplicationState.isTerminated(appState)) {
ApplicationState.UNKNOWN
} else {
appState
}
}

override def getOperationLog: Option[OperationLog] = Option(_operationLog)

// we can not set to other state if it is canceled
Expand Down
Loading