Exclude transitive deps of paimon #6698
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pan3793
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6698 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 684 684
Lines 42279 42279
Branches 5765 5765
======================================
Misses 42279 42279 ☔ View full report in Codecov by Sentry. |
wForget
approved these changes
Sep 18, 2024
pan3793
added a commit
that referenced
this pull request
Sep 18, 2024
# 🔍 Description ## Issue References 🔗 `paimon-spark-3.5` is a bundled jar but still pulls transitive deps. ## Describe Your Solution 🔧 Explicitly excluding transitive deps of paimon. ## Types of changes 🔖 - [x] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Test Plan 🧪 Pass GHA and manually checked. --- # Checklist 📝 - [x] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html) **Be nice. Be informative.** Closes #6698 from pan3793/exclude-paimon. Closes #6698 6048b11 [Cheng Pan] Exclude transitive deps from paimon Authored-by: Cheng Pan <[email protected]> Signed-off-by: Cheng Pan <[email protected]> (cherry picked from commit 635c793) Signed-off-by: Cheng Pan <[email protected]>
|
Thanks, merged to master/1.9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔍 Description
Issue References 🔗
paimon-spark-3.5is a bundled jar but still pulls transitive deps.Describe Your Solution 🔧
Explicitly excluding transitive deps of paimon.
Types of changes 🔖
Test Plan 🧪
Pass GHA and manually checked.
Checklist 📝
Be nice. Be informative.