Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TRINO] Trino engine improve operation log #6387

Closed
wants to merge 1 commit into from

Conversation

lsm1
Copy link
Contributor

@lsm1 lsm1 commented May 14, 2024

trino engine increment mode support fetch log

🔍 Description

Issue References 🔗

This pull request fixes #

Describe Your Solution 🔧

  1. Trino engine supports outputting final status information, and we can also support outputting running information.
  2. In increment mode, the operation status is set to FINISHED quickly, which prevents the client from fetching detailed operation logs. The client is unaware of the exact execution status of the operation. It should be possible to explicitly check if the ResultSet has more data (hasNext), and delay setting the status to output more operation information.

Types of changes 🔖

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Test Plan 🧪

Behavior Without This Pull Request ⚰️

Behavior With This Pull Request 🎉

Related Unit Tests


Checklist 📝

Be nice. Be informative.

trino engine increment mode support fetch log
@lsm1 lsm1 force-pushed the branch-trino-print-info branch from 62e1ea0 to b9b733a Compare May 14, 2024 10:18
@codecov-commenter
Copy link

codecov-commenter commented May 14, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 58.54%. Comparing base (c8e6457) to head (b9b733a).

Files Patch % Lines
...in/scala/org/apache/kyuubi/config/KyuubiConf.scala 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6387      +/-   ##
============================================
- Coverage     58.57%   58.54%   -0.04%     
  Complexity       24       24              
============================================
  Files           653      653              
  Lines         39968    39974       +6     
  Branches       5488     5489       +1     
============================================
- Hits          23411    23401      -10     
- Misses        14058    14074      +16     
  Partials       2499     2499              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cxzl25 cxzl25 added this to the v1.10.0 milestone May 15, 2024
@cxzl25 cxzl25 closed this in 02e1aa3 May 15, 2024
@cxzl25
Copy link
Contributor

cxzl25 commented May 15, 2024

Thanks, merged to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants