[KYUUBI #4515] Capturing process id for kyuubi server launched using run command

[Madhukar98]

…run command

🔍 Description

Issue References 🔗

This pull request fixes # #4515

Describe Your Solution 🔧

Currently, the process ID (PID) for a Kyuubi server launched using bin/kyuubi run is not being captured. This leads to the bin/kyuubi status command incorrectly reporting that the server is not running.
Furthermore, if the bin/kyuubi run command is initiated at the launch of a Docker container, subsequent attempts to run bin/kyuubi start will fail due to the error "ports already occupied".
To resolve these issues and ensure synchronization between the status of the Kyuubi server whether it's launched in the foreground with bin/kyuubi run or in the background with bin/kyuubi start, two changes have been made:

1. A get_pid function has been created to capture the PID of the process launched using the run command.
2. A check has been added before starting a Kyuubi server to ensure that it's not already running in a different mode.

Types of changes 🔖

• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Test Plan 🧪

Behavior Without This Pull Request ⚰️

bin/kyuubi run -> Launches kyuubi server
bin/kyuubi status -> Kyuubi is not running
bin/kyuubi start -> Fails with port already occupied

Behavior With This Pull Request 🎉

bin/kyuubi run -> Launches kyuubi server
bin/kyuubi status -> Kyuubi is running (PID)
bin/kyuubi start -> Kyuubi running as process PID. Stop it first.

Related Unit Tests

---

Checklist 📝

• This patch was not authored or co-authored using Generative Tooling

Be nice. Be informative.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.44%. Comparing base (78e104d) to head (bbee33a).
Report is 226 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #6374      +/-   ##
============================================
- Coverage     58.47%   58.44%   -0.04%     
  Complexity       24       24              
============================================
  Files           653      653              
  Lines         39881    39895      +14     
  Branches       5481     5482       +1     
============================================
- Hits          23319    23315       -4     
- Misses        14070    14080      +10     
- Partials       2492     2500       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[zhouyifan279]

1. grep kyuubi is not sufficient to ensure that this is a Kyuubi Server process. For example, Kyuubi Engine processes also have kyuubi in their info.
2. User may have multiple Kyuubi installations on a single machine. We need to ensure that this Kyuubi Server process is launched using current Kyuubi installation.

[Madhukar98]

Thanks @zhouyifan279 for your feedback. I will work on these.

[Madhukar525722]

Hi @zhouyifan279 , I have updated the implementation, now I am making the selection on

1. org.apache.kyuubi.server.KyuubiServer - Ensures its an server process
2. $KYUUBI_CONF_DIR - Kyuubi conf dir path, displayed in the complete process details. This identifier is choosen to differentiate between the instances, because different instances cant run with same conf, as it will cause port already in use error.

Please review the changes.

Thanks

[Madhukar525722]

Hi @pan3793 @bowenliang123 @zhouyifan279. Please review the implementation. Thanks