-
Notifications
You must be signed in to change notification settings - Fork 916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[KYUUBI #6293] Upgrade Arrow from 12.0.0 to 15.0.2 #6304
Conversation
LICENSE-binary
Outdated
|
||
Eclipse Public License (EPL) 1.0 | ||
-------------------------------- | ||
org.eclipse.collections:eclipse-collections-api |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for dual Licensed dependency, we only need to choose one. for this case, let's choose EDL(listed in category A) https://apache.org/legal/resolved.html
NOTICE-binary
Outdated
* licenses/LICENSE-EDL-1.0.txt (Eclipse Distribution License 1.0 (BSD)) | ||
* licenses/LICENSE-EPL-1.0.txt (Eclipse Public License 1.0) | ||
* HOMEPAGE: | ||
* https://eclipse.dev/collections/index.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: new line at end
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, about the LICENSE information of third-party dependencies mentioned within the NOTICE-binary
file, I have two points of confusion:
-
For instance, for 'lz4-java', its LICENSE information points to 'license/LICENSE.lz4-java.txt', it looks like a file path, but this file is not actually found in the project directory. I am unsure whether this is an error or if there is some other meaning behind it.
-
I have noticed that there are two folders related to licenses at the root of the project:
licenses
andlicenses-binary
, and I am unclear about what types of license files each of these folders should contain.
I would appreciate clarification on how the community differentiates and considers these two directories.
CI still running, I think it will fail eventually because |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6304 +/- ##
============================================
- Coverage 58.47% 58.41% -0.06%
Complexity 24 24
============================================
Files 652 652
Lines 39645 39645
Branches 5454 5454
============================================
- Hits 23181 23159 -22
- Misses 13984 13994 +10
- Partials 2480 2492 +12 ☔ View full report in Codecov by Sentry. |
I will update it in the next commit |
licenses-binary/LICENSE-EPL-1.0.txt
Outdated
@@ -0,0 +1,70 @@ | |||
Eclipse Public License - v 1.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
delete this file, because we don't include EPL 1.0 third-party jars in the binary distribution
@@ -224,3 +224,9 @@ MIT License | |||
----------- | |||
org.slf4j:slf4j-api | |||
org.slf4j:jcl-over-slf4j | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we shaded arrow into kyuubi-hive-jdbc-shaded.jar
, now the transitive deps of arrow changed, the kyuubi-hive-jdbc-shaded/pom.xml
's shading rules need to be updated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if CI pass
Thanks, merged to master |
🔍 Description
Issue References 🔗
This pull request fixes #6293
Describe Your Solution 🔧
Here are my main modifications:
build/dependency.sh --replace
, thedev/dependencyList
file was automatically updated.NOTICE-binary
andLICENSE-binary
files.However, I remain uncertain whether my changes to the LICENSE/NOTICE sections adhere to the community's standards. I kindly request guidance from the community regarding this matter.
Types of changes 🔖
Test Plan 🧪
Behavior Without This Pull Request ⚰️
Behavior With This Pull Request 🎉
Related Unit Tests
Checklist 📝
Be nice. Be informative.