Simple norm the use of kyuubi.operation.result.arrow.timestampAsString and kyuubi.operation.result.format
#5807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please fill the PR description properly and be informative for your changes and reasons briefly. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5807 +/- ##
============================================
- Coverage 61.47% 61.33% -0.14%
Complexity 23 23
============================================
Files 603 608 +5
Lines 35640 35931 +291
Branches 4875 4937 +62
============================================
+ Hits 21908 22039 +131
- Misses 11366 11500 +134
- Partials 2366 2392 +26 ☔ View full report in Codecov by Sentry. |
|
add the desc , thank you @bowenliang123 |
bowenliang123
approved these changes
Dec 3, 2023
|
OK. And please fill the 'Author Self Checklist' of PR description properly. |
bowenliang123
pushed a commit
that referenced
this pull request
Dec 3, 2023
…timestampAsString` and `kyuubi.operation.result.format` # 🔍 Description ## Issue References 🔗 This pull request norm the arrow conf. ## Describe Your Solution 🔧 Using `kyuubi.operation.result.arrow.timestampAsString` and `kyuubi.operation.result.format` string to get conf . To replace as `ARROW_BASED_ROWSET_TIMESTAMP_AS_STRING.key` and `OPERATION_RESULT_FORMAT`. Make it more norm. ## Types of changes 🔖 - [ ] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [x] Other ## Test Plan 🧪 No need test --- # Checklists ## 📝 Author Self Checklist - [x] My code follows the [style guidelines](https://kyuubi.readthedocs.io/en/master/contributing/code/style.html) of this project - [x] I have performed a self-review - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [x] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html) ## 📝 Committer Pre-Merge Checklist - [ ] Pull request title is okay. - [ ] No license issues. - [ ] Milestone correctly set? - [ ] Test coverage is ok - [ ] Assignees are selected. - [ ] Minimum number of approvals - [ ] No changes are requested **Be nice. Be informative.** Closes #5807 from zzzzming95/norm-conf. Closes #5807 9e65bfa [佘志铭] norm the arrow conf Authored-by: 佘志铭 <[email protected]> Signed-off-by: liangbowen <[email protected]> (cherry picked from commit 88c8cc3) Signed-off-by: liangbowen <[email protected]>
|
Thanks, merged to master and branch-1.8 (1.8.1). |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔍 Description
Issue References 🔗
This pull request norm the arrow conf.
Describe Your Solution 🔧
Using
kyuubi.operation.result.arrow.timestampAsStringandkyuubi.operation.result.formatstring to get conf . To replace asARROW_BASED_ROWSET_TIMESTAMP_AS_STRING.keyandOPERATION_RESULT_FORMAT. Make it more norm.Types of changes 🔖
Test Plan 🧪
No need test
Checklists
📝 Author Self Checklist
📝 Committer Pre-Merge Checklist
Be nice. Be informative.