[KYUUBI #5757][AUTHZ] Support alter path-based table for Delta Lake in Authz #5760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaooqinn
reviewed
Nov 24, 2023
| val addColumnsSql = s"ALTER TABLE delta.`$path` ADD COLUMNS (age int)" | ||
| interceptEndsWith[AccessControlException]( | ||
| doAs(someone, sql(addColumnsSql)))( | ||
| s"does not have [write] privilege on [[$path, $path/]]") |
There was a problem hiding this comment.
this behavior looks strange to me, add a column seems to have nothing to do with the path..
There was a problem hiding this comment.
This is how I understand it. The privileges of a path-based table are only read and write. alter add column modifies the schema of the table, so write privilege is required.
|
Thanks, merged to master |
|
Sorry, reverted and reopened it via conflicts |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5760 +/- ##
============================================
- Coverage 61.44% 61.39% -0.06%
Complexity 23 23
============================================
Files 607 607
Lines 35944 35944
Branches 4936 4936
============================================
- Hits 22087 22068 -19
- Misses 11477 11487 +10
- Partials 2380 2389 +9 ☔ View full report in Codecov by Sentry. |
|
Conflit resolved, @yaooqinn |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔍 Description
Issue References 🔗
This pull request fixes #5757
Describe Your Solution 🔧
Add uriDescs.
Types of changes 🔖
Test Plan 🧪
Behavior Without This Pull Request ⚰️
Behavior With This Pull Request 🎉
Related Unit Tests
Checklists
📝 Author Self Checklist
📝 Committer Pre-Merge Checklist
Be nice. Be informative.