[KYUUBI #5447][AUTHZ] Support Hudi DeleteHoodieTableCommand/UpdateHoodieTableCommand/MergeIntoHoodieTableCommand #5482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ateHoodieTableCommand/MergeIntoHoodieTableCommand
Codecov Report
@@ Coverage Diff @@
## master #5482 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 588 588
Lines 33466 33481 +15
Branches 4401 4405 +4
======================================
- Misses 33466 33481 +15
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
...c/main/resources/META-INF/services/org.apache.kyuubi.plugin.spark.authz.serde.QueryExtractor
Outdated
Show resolved
Hide resolved
...c/main/resources/META-INF/services/org.apache.kyuubi.plugin.spark.authz.serde.TableExtractor
Outdated
Show resolved
Hide resolved
...-spark-authz/src/main/scala/org/apache/kyuubi/plugin/spark/authz/serde/tableExtractors.scala
Outdated
Show resolved
Hide resolved
...scala/org/apache/kyuubi/plugin/spark/authz/ranger/HudiCatalogRangerSparkExtensionSuite.scala
Show resolved
Hide resolved
|
And again, please do not forget the positive cases. |
|
The current implementation looks to break the original intention of plan serde layer. |
How about current? match all case. |
bowenliang123
approved these changes
Oct 20, 2023
| @@ -33,7 +33,7 @@ import org.apache.kyuubi.util.AssertionUtils.interceptContains | |||
| */ | |||
| @HudiTest | |||
| class HudiCatalogRangerSparkExtensionSuite extends RangerSparkExtensionSuite { | |||
| override protected val catalogImpl: String = "hive" | |||
| override protected val catalogImpl: String = "in-memory" | |||
There was a problem hiding this comment.
Why we have to change this?
There was a problem hiding this comment.
Why we have to change this?
To trigger a positive case, if not change this, will trigger some hive hms-related derby error and can' run. I have checked that this changing to in-memory the plan is also Hudi's command.
bowenliang123
changed the title
|
Thanks, merged to master. |
davidyuan1223
pushed a commit
to davidyuan1223/kyuubi
that referenced
this pull request
Oct 26, 2023
…ateHoodieTableCommand/MergeIntoHoodieTableCommand ### _Why are the changes needed?_ To close apache#5447. Kyuubi authz Support hudi DeleteHoodieTableCommand/UpdateHoodieTableCommand/MergeIntoHoodieTableCommand - DeleteHoodieTableCommand: https://github.com/apache/hudi/blob/master/hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/hudi/command/DeleteHoodieTableCommand.scala - UpdateHoodieTableCommand: https://github.com/apache/hudi/blob/master/hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/hudi/command/UpdateHoodieTableCommand.scala - MergeIntoHoodieTableCommand: https://github.com/apache/hudi/blob/master/hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/hudi/command/MergeIntoHoodieTableCommand.scala ### _How was this patch tested?_ - [x] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [ ] Add screenshots for manual tests if appropriate - [ ] [Run test](https://kyuubi.readthedocs.io/en/master/contributing/code/testing.html#running-tests) locally before make a pull request ### _Was this patch authored or co-authored using generative AI tooling?_ No Closes apache#5482 from AngersZhuuuu/KYUUBI-5447. Closes apache#5447 2598af2 [Angerszhuuuu] Update HudiCatalogRangerSparkExtensionSuite.scala 08be589 [Angerszhuuuu] Update org.apache.kyuubi.plugin.spark.authz.serde.QueryExtractor 19497d1 [Angerszhuuuu] Update tableExtractors.scala df6e244 [Angerszhuuuu] update 1a72f13 [Angerszhuuuu] update f7ca684 [Angerszhuuuu] Merge branch 'master' into KYUUBI-5447 3700686 [Angerszhuuuu] [KYUUBI apache#5447][AUTHZ] Support hudi DeleteHoodieTableCommand/UpdateHoodieTableCommand/MergeIntoHoodieTableCommand Authored-by: Angerszhuuuu <[email protected]> Signed-off-by: liangbowen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
To close #5447. Kyuubi authz Support hudi DeleteHoodieTableCommand/UpdateHoodieTableCommand/MergeIntoHoodieTableCommand
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before make a pull request
Was this patch authored or co-authored using generative AI tooling?
No