-
Notifications
You must be signed in to change notification settings - Fork 923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[K8S][HELM] Comment license in helm chart NOTES #4313
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4313 +/- ##
============================================
- Coverage 53.43% 53.38% -0.06%
Complexity 13 13
============================================
Files 560 560
Lines 30569 30569
Branches 4139 4139
============================================
- Hits 16334 16318 -16
- Misses 12702 12715 +13
- Partials 1533 1536 +3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
cxzl25
approved these changes
Feb 12, 2023
pan3793
pushed a commit
that referenced
this pull request
Feb 12, 2023
### _Why are the changes needed?_ The changes are needed to hide license text printed after chart installed. Before changes: ``` $ helm install kyuubi ${KYUUBI_HOME}/charts/kyuubi -n kyuubi --create-namespace NAME: kyuubi LAST DEPLOYED: Sat Feb 11 20:35:52 2023 NAMESPACE: kyuubi STATUS: deployed REVISION: 1 TEST SUITE: None NOTES: # # Licensed to the Apache Software Foundation (ASF) under one or more # contributor license agreements. See the NOTICE file distributed with # this work for additional information regarding copyright ownership. # The ASF licenses this file to You under the Apache License, Version 2.0 # (the "License"); you may not use this file except in compliance with # the License. You may obtain a copy of the License at # # http://www.apache.org/licenses/LICENSE-2.0 # # Unless required by applicable law or agreed to in writing, software # distributed under the License is distributed on an "AS IS" BASIS, # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. # See the License for the specific language governing permissions and # limitations under the License. # The chart has been installed! In order to check the release status, use: helm status kyuubi -n kyuubi or for more detailed info helm get all kyuubi -n kyuubi ************************ ******* Services ******* ************************ THRIFT_BINARY: - To access kyuubi-thrift-binary service within the cluster, use the following URL: kyuubi-thrift-binary.kyuubi.svc.cluster.local - To access kyuubi-thrift-binary service from outside the cluster for debugging, run the following command: kubectl port-forward svc/kyuubi-thrift-binary 10009:10009 -n kyuubi and use 127.0.0.1:10009 ``` After changes: ``` $ helm install kyuubi ${KYUUBI_HOME}/charts/kyuubi -n kyuubi --create-namespace NAME: kyuubi LAST DEPLOYED: Sat Feb 11 20:37:45 2023 NAMESPACE: kyuubi STATUS: deployed REVISION: 1 TEST SUITE: None NOTES: The chart has been installed! In order to check the release status, use: helm status kyuubi -n kyuubi or for more detailed info helm get all kyuubi -n kyuubi ************************ ******* Services ******* ************************ THRIFT_BINARY: - To access kyuubi-thrift-binary service within the cluster, use the following URL: kyuubi-thrift-binary.kyuubi.svc.cluster.local - To access kyuubi-thrift-binary service from outside the cluster for debugging, run the following command: kubectl port-forward svc/kyuubi-thrift-binary 10009:10009 -n kyuubi and use 127.0.0.1:10009 ``` ### _How was this patch tested?_ - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [ ] Add screenshots for manual tests if appropriate - [ ] [Run test](https://kyuubi.readthedocs.io/en/master/develop_tools/testing.html#running-tests) locally before make a pull request Closes #4313 from dnskr/comment_license_in_helm_chart_notes. Closes #4313 7cc7663 [dnskr] [K8S][HELM] Comment license in helm chart NOTES Authored-by: dnskr <[email protected]> Signed-off-by: Cheng Pan <[email protected]> (cherry picked from commit 7f86611) Signed-off-by: Cheng Pan <[email protected]>
Thanks, merged to master/1.7 |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
The changes are needed to hide license text printed after chart installed.
Before changes:
After changes:
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before make a pull request