Use eclipse-temurin:8-jdk-focal as default base image
#4288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pan3793
commented
Feb 9, 2023
|
|
||
| FROM maven:3.6-jdk-8 as builder | ||
| FROM eclipse-temurin:8-jdk-focal as builder |
There was a problem hiding this comment.
it's hard to maintain the maven version in multi places, so it's better to use build/mvn to auto-download the expected version.
There was a problem hiding this comment.
ok, and we should cache build/apache-maven* properly in CI jobs, to prevent repeatedly downloading maven.
ulysses-you
approved these changes
Feb 10, 2023
|
Thanks, merged to master |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
eclipse-temurin is the successor for openjdk, see apache/spark#37705
"The core change is: the OS of base image changes debian-bullseye to ubuntu-focal (based on debian bullseye)."
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before make a pull request