Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[K8S][HELM] Add initContainers and containers support to helm chart #4060

Closed
wants to merge 1 commit into from

Conversation

dnskr
Copy link
Contributor

@dnskr dnskr commented Jan 2, 2023

Why are the changes needed?

The changes allow to add initContainers and containers to Kyuubi server pod.

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before make a pull request

Copy link
Member

@pan3793 pan3793 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pan3793 pan3793 added this to the v1.7.0 milestone Jan 3, 2023
@pan3793 pan3793 closed this in 1efc37d Jan 3, 2023
@pan3793
Copy link
Member

pan3793 commented Jan 3, 2023

Thanks, merged to master

@dnskr dnskr deleted the add_initcontainers branch May 11, 2023 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants