[K8S][HELM] Address some PR comments

apache · Jan 15, 2023 · 65e1f59 · 65e1f59
1 parent 36b5fc6
commit 65e1f59
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 12 deletions.
diff --git a/charts/kyuubi/templates/_helpers.tpl b/charts/kyuubi/templates/_helpers.tpl
@@ -16,7 +16,7 @@
 */}}
 
 {{/*
-A comma separated string of enabled frontend protocols, e.g. "MYSQL,REST,THRIFT_BINARY".
+A comma separated string of enabled frontend protocols, e.g. "REST,THRIFT_BINARY".
 For details, see 'kyuubi.frontend.protocols': https://kyuubi.readthedocs.io/en/master/deployment/settings.html#frontend
 */}}
 {{- define "kyuubi.frontend.protocols" -}}

diff --git a/charts/kyuubi/templates/kyuubi-deployment.yaml b/charts/kyuubi/templates/kyuubi-deployment.yaml
@@ -66,7 +66,7 @@ spec:
           {{- if .Values.probe.liveness.enabled }}
           livenessProbe:
             exec:
-              command: ["/bin/sh", "-c", "bin/kyuubi status"]
+              command: ["/bin/bash", "-c", "bin/kyuubi status"]
             initialDelaySeconds: {{ .Values.probe.liveness.initialDelaySeconds }}
             periodSeconds: {{ .Values.probe.liveness.periodSeconds }}
             timeoutSeconds: {{ .Values.probe.liveness.timeoutSeconds }}
@@ -76,7 +76,7 @@ spec:
           {{- if .Values.probe.readiness.enabled }}
           readinessProbe:
             exec:
-              command: [ "/bin/sh", "-c", "$KYUUBI_HOME/bin/kyuubi status" ]
+              command: ["/bin/bash", "-c", "$KYUUBI_HOME/bin/kyuubi status"]
             initialDelaySeconds: {{ .Values.probe.readiness.initialDelaySeconds }}
             periodSeconds: {{ .Values.probe.readiness.periodSeconds }}
             timeoutSeconds: {{ .Values.probe.readiness.timeoutSeconds }}

diff --git a/charts/kyuubi/values.yaml b/charts/kyuubi/values.yaml
@@ -111,17 +111,17 @@ frontend:
 
 kyuubiConfDir: /opt/kyuubi/conf
 kyuubiConf:
-    # The value (templated string) is used for kyuubi-env.sh file
-    # See https://kyuubi.apache.org/docs/latest/deployment/settings.html#environments for more details
-    kyuubiEnv: ~
+  # The value (templated string) is used for kyuubi-env.sh file
+  # See https://kyuubi.apache.org/docs/latest/deployment/settings.html#environments for more details
+  kyuubiEnv: ~
 
-    # The value (templated string) is used for kyuubi-defaults.conf file
-    # See https://kyuubi.apache.org/docs/latest/deployment/settings.html#kyuubi-configurations for more details
-    kyuubiDefaults: ~
+  # The value (templated string) is used for kyuubi-defaults.conf file
+  # See https://kyuubi.apache.org/docs/latest/deployment/settings.html#kyuubi-configurations for more details
+  kyuubiDefaults: ~
 
-    # The value (templated string) is used for log4j2.xml file
-    # See https://kyuubi.apache.org/docs/latest/deployment/settings.html#logging for more details
-    log4j2: ~
+  # The value (templated string) is used for log4j2.xml file
+  # See https://kyuubi.apache.org/docs/latest/deployment/settings.html#logging for more details
+  log4j2: ~
 
 # Environment variables (templated)
 env: []