-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KYLIN-4736 flink upgrade to 1.11.1 #1462
Conversation
@yanghua could you please take a look when free, thank you |
Pull Request Test Coverage Report for Build 6483
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. @zhangayqian Would you please help to review this new PR?
@chenjie-sau @yanghua Thanks!LGTM,works well in my local env (cdh57). |
@@ -64,12 +64,14 @@ public static Configuration getCurrentConfiguration() { | |||
return conf; | |||
} | |||
Configuration conf = hadoopConfig.get(); | |||
conf.set("fs.hdfs.impl.disable.cache", "true"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why it needs to add this parameter here? and will it impact other functions, because there are some place calling this functions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This configuration will not affect other functions, it has been verified,This is done in order to prevent the FileSystem from shutting down prematurely, resulting in abnormal file information acquisition
This reverts commit c081b29
Proposed changes
flink upgrade to 1.11.1