Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix glog may buffer the stdout's output #2131

Merged
merged 1 commit into from
Mar 2, 2024
Merged

Conversation

i18nsite
Copy link
Contributor

@i18nsite i18nsite commented Mar 2, 2024

fix #1883

Copy link

sonarcloud bot commented Mar 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@git-hulk git-hulk changed the title Update main.cc Fix glog may buffer the stdout's output Mar 2, 2024
@git-hulk git-hulk merged commit 2ec78bc into apache:unstable Mar 2, 2024
30 checks passed
@PragmaTwice
Copy link
Member

I believe this change will have a significant impact as it removes the global stdout buffer. (e.g. logging behavior, performance without buffer..)

I suggest that we DO NOT pick this patch to version 2.8.0 until a thorough investigation is conducted.

cc @git-hulk @caipengbo

@git-hulk
Copy link
Member

git-hulk commented Mar 2, 2024

@PragmaTwice Thanks for raising this potential issue, I have linked this in the release proposal.

@i18nsite
Copy link
Contributor Author

i18nsite commented Mar 7, 2024

google/glog#943
FLAGS_logtostdout does not seem to follow FLAGS_logbuflevel
是这个问题导致的,如果去修glog应该更好

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

redis.log not flush in docker on mac OrbStack
4 participants