Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing default karaf.key #901

Merged
merged 1 commit into from
Jul 30, 2019
Merged

Removing default karaf.key #901

merged 1 commit into from
Jul 30, 2019

Conversation

coheigea
Copy link
Contributor

Karaf bundles a default "karaf.key" for SSH. This is not good security practice, and it doesn't really have any practical use unless the user uncomments the hard-coded key in etc/keys.properties. The latter is not something we should support, if the user wants to use keys.properties, then the user should generate a keypair and put the public key into keys.properties as explained in the manual.

I tested that SSH'ing into Karaf using both a password, and a key defined in keys.properties works correctly with this fix, both for openssh and using bin/client.

@jbonofre jbonofre self-requested a review July 11, 2019 04:57
@jbonofre
Copy link
Member

It seems that the GitHub/Jenkins integration doesn't work since yesterday (not only for Karaf, but globally). I'm checking with infra.

@jbonofre
Copy link
Member

I gonna test this PR manually waiting fix on github/jenkins integration.

@jbonofre
Copy link
Member

The tests failures have been fixed. I'm rebasing to test.

Copy link
Member

@jbonofre jbonofre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@jbonofre jbonofre merged commit c0ffaea into apache:master Jul 30, 2019
@coheigea coheigea deleted the hostkey branch August 7, 2019 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants