KAFKA-10556: NPE if sasl.mechanism is unrecognized #9356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
@rondagostino Thanks for the PR, looks good. Left one comment.
...ts/src/main/java/org/apache/kafka/common/security/authenticator/SaslClientAuthenticator.java
Show resolved
Hide resolved
rajinisivaram
approved these changes
Sep 30, 2020
There was a problem hiding this comment.
@rondagostino Thanks for the updates, LGTM. Will merge when builds complete.
|
Test failures look like flaky tests, there are not related to the PR. Merging to trunk. |
|
@rondagostino It seems |
|
Yeah, we no longer contact the server if the client doesn't recognize the SASL mechanism. The PR at #9372 fixes this test, which was using an unknown SASL mechanism (SCRAM-SHA-256) according to the JAAS config (PLAIN). Now it will use PLAIN and bad credentials. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.
Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.
Committer Checklist (excluded from commit message)