Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HOTFIX: fix StreamsConfig build failure #8424

Merged
merged 1 commit into from
Apr 4, 2020
Merged

HOTFIX: fix StreamsConfig build failure #8424

merged 1 commit into from
Apr 4, 2020

Conversation

abbccdda
Copy link
Contributor

@abbccdda abbccdda commented Apr 4, 2020

The last merged code caused some unexpected failure: ab5e4f5

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@mjsax
Copy link
Member

mjsax commented Apr 4, 2020

Retest this please

@mjsax mjsax added the streams label Apr 4, 2020
@mjsax mjsax mentioned this pull request Apr 4, 2020
Merged
3 tasks
@abbccdda abbccdda mentioned this pull request Apr 4, 2020
Merged
3 tasks
@guozhangwang
Copy link
Contributor

LGTM. Please feel free to merge.

@mjsax mjsax merged commit 0eab920 into apache:trunk Apr 4, 2020
@mjsax
Copy link
Member

mjsax commented Apr 4, 2020

Thanks for the quick fix @abbccdda. Merged to trunk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chia7712 chia7712 chia7712 approved these changes

Assignees
No one assigned
Labels
streams
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@abbccdda @mjsax @guozhangwang @chia7712