Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KAFKA-9663: Doc some null returns in KafkaStreams #8228

Merged

Conversation

tombentley
Copy link
Contributor

Documents the possibility of null return value in KafkaStreams.getMetadataForKey(), and KafkaStreams.queryMetadataForKey().

This fixes KAFKA-9663.

@tombentley
Copy link
Contributor Author

@guozhangwang, @mjsax please could you review?

@tombentley tombentley force-pushed the KAFKA-9663-getMetadataForKey-javadoc-null branch from 6646b37 to ab5d4a9 Compare March 5, 2020 13:05
@@ -1083,7 +1083,8 @@ public void cleanUp() {
* @param keySerializer serializer for the key
* @param <K> key type
* @return {@link StreamsMetadata} for the {@code KafkaStreams} instance with the provided {@code storeName} and
* {@code key} of this application or {@link StreamsMetadata#NOT_AVAILABLE} if Kafka Streams is (re-)initializing
* {@code key} of this application or {@link StreamsMetadata#NOT_AVAILABLE} if Kafka Streams is (re-)initializing,
* or null if no matching metadata could be found.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: null -> {@code null}

Same for all other cases

@mjsax mjsax added the streams label Mar 5, 2020
@tombentley tombentley closed this Mar 5, 2020
@tombentley tombentley force-pushed the KAFKA-9663-getMetadataForKey-javadoc-null branch from ab5d4a9 to 75268cb Compare March 5, 2020 18:07
Documents the possibility of null return value in
KafkaStreams.getMetadataForKey(), and KafkaStreams.queryMetadataForKey().

This fixes KAFKA-9663.
@tombentley
Copy link
Contributor Author

Closed in error. Now fixed @mjsax.

@tombentley tombentley reopened this Mar 5, 2020
@mjsax mjsax merged commit 2775572 into apache:trunk Mar 7, 2020
@mjsax
Copy link
Member

mjsax commented Mar 7, 2020

Thanks for the PR @tombentley! Merged to trunk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants