Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KAFKA-9662: Wait for consumer offset reset in throttle test to avoid losing early messages #8227

Merged
merged 1 commit into from
Mar 6, 2020

Conversation

rajinisivaram
Copy link
Contributor

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@rajinisivaram rajinisivaram requested a review from mumrah March 5, 2020 11:53
@rajinisivaram
Copy link
Contributor Author

Ran throttling_test three times, twice with this commit on 2.5 and once on trunk. Both the throttling tests passed in all three cases. Other system tests are not affected since they use consumers with default from_beginning=True.

Copy link
Member

@mumrah mumrah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mumrah mumrah merged commit 6b41993 into apache:trunk Mar 6, 2020
mumrah pushed a commit that referenced this pull request Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants