-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KAFKA-9601: Stop logging raw connector config values #8165
Conversation
@rhauch got a quick second? |
@C0urante I may be missing something, but AbstractConfig doesn't have a toString() method, which means that the log message you're changing may have, at worst, output the |
@rhauch the object that gets logged isn't the kafka/connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerConnector.java Line 77 in 9064026
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks, @C0urante.
Neither test failure was related to Connect. |
Author: Chris Egerton <[email protected]> Reviewer: Randall Hauch <[email protected]>
Author: Chris Egerton <[email protected]> Reviewer: Randall Hauch <[email protected]>
Author: Chris Egerton <[email protected]> Reviewer: Randall Hauch <[email protected]>
Author: Chris Egerton <[email protected]> Reviewer: Randall Hauch <[email protected]>
Author: Chris Egerton <[email protected]> Reviewer: Randall Hauch <[email protected]>
Author: Chris Egerton <[email protected]> Reviewer: Randall Hauch <[email protected]>
Author: Chris Egerton <[email protected]> Reviewer: Randall Hauch <[email protected]>
Author: Chris Egerton <[email protected]> Reviewer: Randall Hauch <[email protected]>
Author: Chris Egerton <[email protected]> Reviewer: Randall Hauch <[email protected]>
Jira
whoopsie daisy