Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KAFKA-9601: Stop logging raw connector config values #8165

Merged
merged 1 commit into from
Feb 26, 2020

Conversation

C0urante
Copy link
Contributor

Jira

whoopsie daisy

@C0urante
Copy link
Contributor Author

@rhauch got a quick second?

@C0urante C0urante requested a review from rhauch February 25, 2020 06:36
@rhauch
Copy link
Contributor

rhauch commented Feb 25, 2020

@C0urante I may be missing something, but AbstractConfig doesn't have a toString() method, which means that the log message you're changing may have, at worst, output the Object.toString() that would not list the key and values.

@C0urante
Copy link
Contributor Author

@rhauch the object that gets logged isn't the AbstractConfig itself, but the original string/string map that it was instantiated with. You can see this in the line before the one I've changed:

this.config = connectorConfig.originalsStrings();

Copy link
Contributor

@rhauch rhauch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @C0urante.

@rhauch
Copy link
Contributor

rhauch commented Feb 26, 2020

Neither test failure was related to Connect.

@rhauch rhauch merged commit b9e3fa2 into apache:trunk Feb 26, 2020
rhauch pushed a commit that referenced this pull request Feb 26, 2020
rhauch pushed a commit that referenced this pull request Feb 26, 2020
rhauch pushed a commit that referenced this pull request Feb 26, 2020
rhauch pushed a commit that referenced this pull request Feb 26, 2020
rhauch pushed a commit that referenced this pull request Feb 26, 2020
rhauch pushed a commit that referenced this pull request Feb 26, 2020
rhauch pushed a commit that referenced this pull request Feb 26, 2020
rhauch pushed a commit that referenced this pull request Feb 26, 2020
qq619618919 pushed a commit to qq619618919/kafka that referenced this pull request May 12, 2020
@C0urante C0urante deleted the patch-1 branch November 5, 2020 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants