Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KAFKA-3080: Fix ConsoleConsumerTest by checking version when service is started #770

Closed
wants to merge 1 commit into from
Closed

KAFKA-3080: Fix ConsoleConsumerTest by checking version when service is started #770

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/kafkatest/services/console_consumer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,6 @@ def __init__(self, context, num_nodes, kafka, topic, group_id="test-consumer-gro
self.messages_consumed = {idx: [] for idx in range(1, num_nodes + 1)}
self.client_id = client_id
self.print_key = print_key
self.log_values = True if version == TRUNK else False
self.log_level = "TRACE"

def prop_file(self, node):
Expand Down Expand Up @@ -192,7 +191,8 @@ def start_cmd(self, node):
if self.print_key:
cmd += " --property print.key=true"

if self.log_values:
# LoggingMessageFormatter was introduced in 0.9.0.0
if node.version > LATEST_0_8_2:
cmd+=" --formatter kafka.tools.LoggingMessageFormatter"

cmd += " 2>> %(stderr)s | tee -a %(stdout)s &" % args
Expand Down