KAFKA-8894: Bump streams test topic deletion assertion timeout from 30s to 60s #7330
Conversation
…0s to 60s We have seen rare flakiness in this assertion - all of streams' internal topics would not get deleted within the 30 second window. Increasing to 60 seconds should reduce the occurrence.
|
Related failures were: I had seen both fail in one Jenkins run |
| Topic.GROUP_METADATA_TOPIC_NAME, intermediateUserTopic); | ||
| } else { | ||
| cluster.waitForRemainingTopics(30000, INPUT_TOPIC, OUTPUT_TOPIC, OUTPUT_TOPIC_2, OUTPUT_TOPIC_2_RERUN, | ||
| cluster.waitForRemainingTopics(60000, INPUT_TOPIC, OUTPUT_TOPIC, OUTPUT_TOPIC_2, OUTPUT_TOPIC_2_RERUN, |
There was a problem hiding this comment.
I am always a little "concerned" about bumping timeouts if we don't understand why it actually fails. 30 seconds seems like quite some time.
How long is deleting topics supposed to take? As far as I understand, we send a single request to delete all internal topics via AdminClient to the brokers. Is there a relationship between the expected completion time to delete all topic the the number of topics in the request?
\cc @cmccabe
There was a problem hiding this comment.
There is a relationship to the number of partitions, as far as I'm aware.
I don't believe it is normal to take more than 30 seconds in practice but I can imagine it is possible when the Jenkins workers are overloaded. That's my intuition as to why it failed once
There was a problem hiding this comment.
I looked at the test and at least one failed test namely testReprocessingFromDateTimeAfterResetWithoutIntermediateUserTopic does not have any internal topics to create, and hence none to delete. So it's not clear if bumping up the timeout would help here.
I'd suggest we first augment the error messages to include the expected topics and the actual topics
|
I filed another PR related to this ticket: #8208 |
|
Closing this PR as the corresponding Jira ticket is marked "resolved". |
We have seen rare flakiness in this assertion - all of streams' internal topics would not get deleted within the 30 second window. Increasing to 60 seconds should reduce the occurrence.