Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MINOR: Remove unused TopicAndPartition and remove unused symbols #7119

Merged
merged 1 commit into from
Jul 28, 2019
Merged

MINOR: Remove unused TopicAndPartition and remove unused symbols #7119

merged 1 commit into from
Jul 28, 2019

Conversation

ijuma
Copy link
Member

@ijuma ijuma commented Jul 26, 2019

With the removal of ZkUtils and AdminUtils, TopicAndPartition is finally
unused.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@ijuma ijuma requested a review from omkreddy July 27, 2019 19:26
@ijuma
Copy link
Member Author

ijuma commented Jul 27, 2019

retest this please

omkreddy
omkreddy approved these changes Jul 28, 2019
View reviewed changes
Copy link
Contributor

@omkreddy omkreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ijuma Thanks for the PR. LGTM.

@ijuma
Copy link
Member Author

ijuma commented Jul 28, 2019

Thanks for the review. 2 green builds and 1 flaky test failure for JDK 8 and Scala 2.11:

kafka.api.SaslScramSslEndToEndAuthorizationTest.testNoDescribeProduceOrConsumeWithoutTopicDescribeAcl

Merging to trunk.

@ijuma ijuma merged commit acf507c into apache:trunk Jul 28, 2019
@ijuma ijuma deleted the remove-topic-and-partition branch July 28, 2019 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omkreddy omkreddy omkreddy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ijuma @omkreddy