Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KAFKA-2781: Only require signing artifacts when uploading archives. #461

Closed

Conversation

ewencp
Copy link
Contributor

@ewencp ewencp commented Nov 9, 2015

No description provided.

@junrao
Copy link
Contributor

junrao commented Nov 9, 2015

Thanks for the patch. LGTM.

@asfgit asfgit closed this in a24f9a2 Nov 9, 2015
asfgit pushed a commit that referenced this pull request Nov 9, 2015
Author: Ewen Cheslack-Postava <[email protected]>

Reviewers: Jun Rao <[email protected]>

Closes #461 from ewencp/kafka-2781-no-signing-for-install

(cherry picked from commit a24f9a2)
Signed-off-by: Jun Rao <[email protected]>
ewencp referenced this pull request in confluentinc/kafka Nov 18, 2015
Author: Ewen Cheslack-Postava <[email protected]>

Reviewers: Jun Rao <[email protected]>

Closes #461 from ewencp/kafka-2781-no-signing-for-install
hachikuji pushed a commit to hachikuji/kafka that referenced this pull request Dec 11, 2020
* Fix Broker Controller discovery w/ LocalLogManager

- Configure broker/controller to use a common `metadata.log.dir`
- Fix metadata checkpoints discovery to include the `metadata.log.dir`
- Minor fix in `BrokerToControllerChannelManager` to use the correct
controller for ManualMetadataUpdate in the NetworkClient

* Address review comments

* Add comment

* Addressing review comment: Use a hash-set to dedupe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants